Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events with no arguments are written with an extra space #73

Open
TheBoxyBear opened this issue Jul 26, 2024 · 0 comments
Open

Events with no arguments are written with an extra space #73

TheBoxyBear opened this issue Jul 26, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@TheBoxyBear
Copy link
Owner

TheBoxyBear commented Jul 26, 2024

Severity: Minor

Chart editors write event data as "type <arg1> <arg2>" with the space between the event type and arguments ommitted when no arguments are present. Although a space after the type is typically supported, some programs may have issues reading such events and it overalls goes against the norm of .chart files.

Steps to reproduce

  1. Create a Song

  2. Add an event at position 0 to GlobalEvents created from the event data phrase_start.

  3. Save the song to a .chart file.

Expected
The file contains the line 0 = E "phrase_start" under the [Events] section.

Actual
The line is 0 = E "phrase_start "

@TheBoxyBear TheBoxyBear added the bug Something isn't working label Jul 26, 2024
@TheBoxyBear TheBoxyBear added this to the Release milestone Jul 26, 2024
@TheBoxyBear TheBoxyBear added the good first issue Good for newcomers label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant