Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect release guide on github pages #284

Closed
PolinaSavelyeva opened this issue Nov 13, 2023 · 3 comments · Fixed by #285
Closed

Incorrect release guide on github pages #284

PolinaSavelyeva opened this issue Nov 13, 2023 · 3 comments · Fixed by #285

Comments

@PolinaSavelyeva
Copy link
Contributor

Describe the bug
The steps to add NUGET_TOKEN from https://www.jimmybyrd.me/MiniScaffold/Tutorials/Getting_Started_With_Libraries.html#Add-your-NUGET_TOKEN-to-your-environment are incorrect.

Expected behavior
"Create an Environment on your repository named nuget." should be "Add your NuGet API key as repository secret NUGET_TOKEN to Actions secrets", as it mentioned in the project's README.

@TheAngryByrd
Copy link
Owner

It’s the other way around. The readme is incorrect. Would you like to send a PR to fix this?

@PolinaSavelyeva
Copy link
Contributor Author

I've just checked the latest library template and still got error message while following steps described on pages.

Could not push package /home/runner/work/Test/Test/dist/MyCoolNewLib.1.0.0.nupkg due to missing credentials 
for the url https://www.nuget.org/api/v2/package. Please specify a NuGet API key via the command line, the 
environment variable "nugetkey", or by using 'paket config add-token'.

Using Repository secrets instead of Environment secrets fixes the issue. If I understood correctly, i would like to send a PR.

@TheAngryByrd
Copy link
Owner

Oh you're right the template is missing the environment like in IcedTasks which should be set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants