Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting ifcLoader.settings.includeProperties to "false" has no effect #554

Open
5 tasks done
andy-wrks opened this issue Jan 12, 2025 · 0 comments
Open
5 tasks done
Labels
bug Something isn't working

Comments

@andy-wrks
Copy link

Describe the bug 📝

It seems that the setting ifcLoader.settings.includeProperties isn't respected when loading an IFC file.

It could be that the bug is in the code below.
It looks like when calling ifcLoader.load(), IfcJsonExporter is used without checking this setting.

Source file:
https://github.com/ThatOpen/engine_components/blob/main/packages/core/src/fragments/IfcLoader/index.ts

Code:
image

Disabling this setting can be useful when properties are not needed or handled independently. Skipping this step will then reduce computation time.

Reproduction ▶️

No response

Steps to reproduce 🔢

...
ifcLoader.settings.includeProperties = false;
...
const group = await ifcLoader.load(buffer);
const props = group.getLocalProperties();

// the properties are present, but they shouldn't

System Info 💻

components: 2.4.3
web-ifc: 0.0.66

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • Check that this is a concrete bug. For Q&A join our Community.
  • The provided reproduction is a minimal reproducible example of the bug.
@andy-wrks andy-wrks added the bug Something isn't working label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant