IDSFacet - Bounds parameter comparrison error

[brettburling]

Describe the bug 📝

I would like to define a property facet to check the minimum length of walls
I expect to be able to do this using a facet parameter of "bounds" type and specifying a min value
The check always fails

I belive the evalRequirement method in the IDSFacet class has the comparisons reversed:

Current code is:

minPass = minInclusive ? value <= min : value < min;`

I belive it should be:

minPass = minInclusive ? value >= min : value > min;`

I created the property facet with this code:

//create property facet
const propertyFacet = new OBC.IDSProperty(
    ifcStore.components,
    { type: 'enumeration', parameter: ['Dimensions'] },
    { type: 'simple', parameter: 'Length' }
  )

//set value requirement
 propertyFacet.value = {
    type: 'bounds',
    parameter: {
      min: 1000,
      minInclusive: false
    }
  }

Here is the console log of the result from the IDS specification test method:

You can see:

1. the check fails
2. the current value (10000)
3. the min required value (1000)

Reproduction ▶️

No response

Steps to reproduce 🔢

No response

System Info 💻

System:
    OS: Windows 11 10.0.22631
    CPU: (12) x64 Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz
    Memory: 7.95 GB / 31.73 GB
  Binaries:
    Node: 20.11.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 10.2.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 131.0.6778.86
    Edge: Chromium (127.0.2651.74)
    Internet Explorer: 11.0.22621.3527

Used Package Manager 📦

yarn

Error Trace/Logs 📃

No response

Validations ✅

• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
• Check that this is a concrete bug. For Q&A join our Community.
• The provided reproduction is a minimal reproducible example of the bug.

[brettburling]

@HoyosJuan any updates on this? is it a legit bug or have i miss understood?

[HoyosJuan]

Hey @brettburling! Hope you are fine and sorry about the delay 🙏

You're completely right. I already solved this in commit 2c7461f. The NPM version is 2.4.4.

Let me know if the problem is solved for you!