Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): Slot's parent missing in UIComponents #239

Merged
merged 2 commits into from
Dec 29, 2023
Merged

fix(components): Slot's parent missing in UIComponents #239

merged 2 commits into from
Dec 29, 2023

Conversation

HoyosJuan
Copy link
Member

Description

This PR solves issue #237.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@HoyosJuan HoyosJuan added the bug Something isn't working label Dec 29, 2023
@HoyosJuan HoyosJuan linked an issue Dec 29, 2023 that may be closed by this pull request
Slot's parent missing in UIComponents #237
Closed
2 tasks
@HoyosJuan HoyosJuan merged commit c671e18 into ThatOpen:main Dec 29, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Dec 29, 2023
Merged
@HoyosJuan HoyosJuan deleted the 237-slots-parent-missing-in-uicomponents branch December 29, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slot's parent missing in UIComponents
1 participant
@HoyosJuan