Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing navigation between FirstPerson and Orbit or Pan breaks Orbit/Pan #184

Closed
5 tasks done
radoslawflis opened this issue Nov 28, 2023 · 1 comment
Closed
5 tasks done
Assignees
Labels
bug Something isn't working

Comments

@radoslawflis
Copy link

Describe the bug 📝

There is a problem when changing navigation from first person to orbit and vice versa. First person breaks orbit.
I tested it out in my app and seems to have exactly the same problem when applying 1.FirstPerson 2.Orbit, Orbit doesn't work properly, the pivot point is still the same.
Basically, FirstPerson navigation breaks Orbit navigation or Pan (you called it Plan) navigation.

Test it out in the app:

cameraComponent.setNavigationMode('Orbit');
cameraComponent.setNavigationMode('FirstPerson');
image
The same issue is on the official open platform as on the picture

Reproduction ▶️

No response

Steps to reproduce 🔢

  1. Set Navigation to mode First Person
  2. Switch to navigation mode Orbit or Pan
    In case of Orbit there will be problem with pivot point, in case of pan there will be issue with speed of truck movement (to slow)

System Info 💻

{
  "name": "ifc-model",
  "private": true,
  "version": "0.0.0",
  "type": "module",
  "scripts": {
    "dev": "vite",
    "build": "vite build",
    "preview": "vite preview"
  },
  "devDependencies": {
    "vite": "^5.0.0"
  },
  "dependencies": {
    "bootstrap": "^5.2.3",
    "camera-controls": "^2.7.3",
    "openbim-components": "1.1.1",
    "three": "^0.152.2"
  }
}

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • Check that this is a concrete bug. For Q&A join our Community.
  • The provided reproduction is a minimal reproducible example of the bug.
@radoslawflis radoslawflis added the bug Something isn't working label Nov 28, 2023
@HoyosJuan HoyosJuan self-assigned this Nov 28, 2023
@HoyosJuan
Copy link
Member

This has been solved in PR #236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants