Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are the languageOverrides in other languages? #686

Open
irbian opened this issue Jun 6, 2024 · 2 comments
Open

Where are the languageOverrides in other languages? #686

irbian opened this issue Jun 6, 2024 · 2 comments

Comments

@irbian
Copy link

irbian commented Jun 6, 2024

Please, correct me if some of the next points is false

  • languageOverrides is the proper way to translate the terriamap interface. There is no translation.json. Texts exclusive for the interface are there and only there
  • There is no default translation for other languages different from english. Is my responsability to implemente it
  • There is no connection to weblate

Did I miss something? Any plan to support this?

@tephenavies
Copy link
Member

Hi @irbian. Most of the strings in Terria's UI are set and translated within TerriaJS/terriajs and connected to weblate. There are some strings in TerriaMap's languageOverrides.json - I think these are all strings that are only referred to in TerriaMap's default config.json. There are no translations to other languages available for these strings, and no connection to weblate to be able to easily translate them.

TerriaMap's languageOverrides.json file is meant to provide an easy way for map owners to override translation.json for some strings in their map. I don't think it's a good place for these default config.json strings. Maybe these default strings could be moved from the TerriaMap's languageOverrides.json to translation.json files in the terriajs repository so that they can be translated easily.

@irbian
Copy link
Author

irbian commented Sep 20, 2024

Maybe these default strings could be moved from the TerriaMap's languageOverrides.json to translation.json files in the terriajs repository so that they can be translated easily.

I guess the problem is that it's not adequate to have translations in terriajs that belong to terria-map, but being the case, maybe the best is to do an exception?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants