Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dom): fix dom memory leak #3628

Merged
merged 2 commits into from
Nov 22, 2023
Merged

fix(dom): fix dom memory leak #3628

merged 2 commits into from
Nov 22, 2023

Conversation

ilikethese
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 22, 2023

Hi, @ilikethese. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@ilikethese ilikethese force-pushed the ilikethese/fix/serializer_free_buffer branch from 6062cf6 to 0a93210 Compare November 22, 2023 06:24
siguangli
siguangli previously approved these changes Nov 22, 2023
View reviewed changes
etkmao
etkmao previously approved these changes Nov 22, 2023
View reviewed changes
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 22, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 22, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) November 22, 2023 06:36
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 22, 2023
@siguangli siguangli added the action(squash-merge) Squash and merge action label Nov 22, 2023
@hippy-actions hippy-actions bot disabled auto-merge November 22, 2023 06:53
@hippy-actions hippy-actions bot enabled auto-merge (squash) November 22, 2023 06:53
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Nov 22, 2023
@siguangli siguangli added the action(squash-merge) Squash and merge action label Nov 22, 2023
@hippy-actions hippy-actions bot disabled auto-merge November 22, 2023 07:00
@hippy-actions hippy-actions bot enabled auto-merge (squash) November 22, 2023 07:00
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Nov 22, 2023
@ilikethese ilikethese dismissed stale reviews from etkmao and siguangli via 8929873 November 22, 2023 07:03
@ilikethese ilikethese force-pushed the ilikethese/fix/serializer_free_buffer branch from d9f8b3e to 8929873 Compare November 22, 2023 07:03
@siguangli siguangli added the action(squash-merge) Squash and merge action label Nov 22, 2023
@hippy-actions hippy-actions bot disabled auto-merge November 22, 2023 07:05
@hippy-actions hippy-actions bot enabled auto-merge (squash) November 22, 2023 07:05
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Nov 22, 2023
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 22, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 22, 2023
@hippy-actions hippy-actions bot disabled auto-merge November 22, 2023 07:13
@hippy-actions hippy-actions bot enabled auto-merge (rebase) November 22, 2023 07:13
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 22, 2023
@siguangli siguangli added action(squash-merge) Squash and merge action action(rebase-merge) Rebase and merge action (maybe privileged) labels Nov 22, 2023
@hippy-actions hippy-actions bot disabled auto-merge November 22, 2023 07:14
@hippy-actions hippy-actions bot enabled auto-merge (squash) November 22, 2023 07:14
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Nov 22, 2023
@hippy-actions hippy-actions bot disabled auto-merge November 22, 2023 07:14
@hippy-actions hippy-actions bot enabled auto-merge (rebase) November 22, 2023 07:14
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 22, 2023
@siguangli siguangli disabled auto-merge November 22, 2023 07:21
@siguangli siguangli merged commit 117e087 into Tencent:main Nov 22, 2023
53 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siguangli siguangli siguangli approved these changes

@etkmao etkmao etkmao approved these changes

@iPel iPel Awaiting requested review from iPel iPel is a code owner

Assignees
No one assigned
Labels
dom: tree module: footstone renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilikethese @siguangli @etkmao @open-hippy