-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bower.json main section is "illegal" to bower spec #7
Comments
OK, after thinking more about this and looking how other font libraries, like Font Aweseom, handle their bower.json files it kind of makes sense to include the font files and the But I still would suggest to only include one file per filetype, no minified file and no globs. "main": [
"css/materialdesignicons.css",
"scss/materialdesignicons.scss",
"fonts/materialdesignicons-webfont.eot",
"fonts/materialdesignicons-webfont.svg",
"fonts/materialdesignicons-webfont.ttf",
"fonts/materialdesignicons-webfont.woff",
"fonts/materialdesignicons-webfont.woff2"
] |
AFAIK, in the new bower specifications, if there is a .less or .scss file, you should not include the .css People needing .css should override their bower.json Refers to FortAwesome/Font-Awesome#6227 Hope it helps |
@tagliala thanks for pointing this out! I guess many people are using bower with wiredep, so we should probably not break this until the issues are resolved. But still having the |
+1 on improving this. By now, I am relying on Bower's "overrides": {
"mdi": {
"main": [
"scss/materialdesignicons.scss"
]
}
} |
This change will be in the next release by the way. Was an oversight it didn't get into the |
https://github.com/Templarian/MaterialDesign-Webfont/blob/master/bower.json I think |
From the bower.json spec:
Because of this with your current configuration wiredep always includes the normal an the minfied css file.
So the main section should only include the css file:
The text was updated successfully, but these errors were encountered: