Update tedious package #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werewolfboy13
requested changes
Jan 13, 2023
|
I think our dependence on Tedious is due to Sequelize, and its an optional dependency there if I'm reading yarn info correctly. @werewolfboy13 I know you may hesitate, but this should a low impact. |
I just want nothing to break, if it's optional should be fine. I'll push this on my internal tools and see what happens. This will occur in a couple days or so. |
werewolfboy13
approved these changes
Jan 24, 2023
ect0s
approved these changes
Jan 24, 2023
Thomas-Smyth
changed the title
Thomas-Smyth
added
minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version resolves a critical bug around xml dom.
Ref: GHSA-crh6-fp67-6883
Currently still testing impacts of this major version change but it hasnt broken my MariaDB connection for the app or SSJS so far.
*Testing on RHEL9 NOT WINDOWS so could be OS specific breakage i'd miss.
This is probably low-priority for the project as i dont think we do anything with untrusted XML.