Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 4 Support #5699

Closed
canastro opened this issue Jul 12, 2023 · 3 comments · Fixed by #5716
Closed

Svelte 4 Support #5699

canastro opened this issue Jul 12, 2023 · 3 comments · Fixed by #5716

Comments

@canastro
Copy link

canastro commented Jul 12, 2023

Describe the bug

Currently svelte-query has a peerDependency on "svelte": "^3.54.0", now that Svelte 4 has been release it would be nice to update this peer dep version range.

Your minimal, reproducible example

N/A

Steps to reproduce

  1. Go to any example
  2. Update your svelte version to 4
  3. Install
  4. You'll get a unmet peer dependency

Expected behavior

As I user I expect to be able to upgrade my app to svelte 4.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

  • OS: any

Tanstack Query adapter

None

TanStack Query version

4.29.19

TypeScript version

5.0.4

Additional context

No response

@inzanez
Copy link

inzanez commented Jul 12, 2023

Also looking for this.

@TkDodo
Copy link
Collaborator

TkDodo commented Jul 14, 2023

@lachlancollins FYI

@lachlancollins
Copy link
Member

@canastro I've properly bumped this in the v5 alpha, but didn't bump it in the v4 branch. I'll do that now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants