Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map "pool" to "max_connections" #59

Closed
nirvdrum opened this issue Dec 31, 2013 · 1 comment
Closed

Map "pool" to "max_connections" #59

nirvdrum opened this issue Dec 31, 2013 · 1 comment

Comments

@nirvdrum
Copy link

This is likely my fault, but I assumed that sequel-rails remapped most of ActiveRecord's parameters in database.yml to Sequel's. As it turns out, Sequel uses a "max_connections" parameter, not "pool" to configure the pool size. The result is I've been running with a pool size of 4 connections in production for an embarrassingly long time. Fixing this resolved several issues for us.

Since the configuration mapper seems to already handle other attribute mappings, perhaps extending it handle the "pool" parameter as well would be beneficial.

@JonathanTron
Copy link
Member

Thanks for reporting it, if it creates confusion and issue on your side it's definitely a bug. I'll wait for the CI run to finish and publish a 0.9.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants