Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres database create ignores some database.yml settings #55

Closed
adamgotterer opened this issue Oct 8, 2013 · 3 comments
Closed

Postgres database create ignores some database.yml settings #55

adamgotterer opened this issue Oct 8, 2013 · 3 comments

Comments

@adamgotterer
Copy link

In my database.yml I have settings for collate, ctype and template. These are being ignored in storage/postgres.rb. Would be great to have support for these since trying to change the encoding on an environment set to something different raises encoding errors. Might even want to consider just using the Sequel create_function_sql in lib/sequel/adapters/shared/postgres.rb.

@JonathanTron
Copy link
Member

Hi @adamgotterer, thanks for your report. Indeed they are ignored, I will add them.

About the Sequel create_function_sql, I don't get how it would be useful for this case, mind to explain?

@adamgotterer
Copy link
Author

Thanks for fixing quickly.

The reason I suggested using the built in Sequel functions is so there is no discrepancy in the functionality. I had just assumed that it was powered by Sequel and that the settings and options would match.

Thanks again. When is the next release to RubyGems?

@JonathanTron
Copy link
Member

You're welcome, I will push a release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants