-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This tempts admins into installing insecure packages to make the warning go away, even going so far as to [impurely modify running containers](nextcloud/docker#1414 (comment)). Changing the warning to trigger if the php-imagick module is loaded is more in line with the actual upstream recommendation, and hopefully helps unsuspecting users who have hacked around the warning in the past realize this. Draft because: - [ ] Untested (will try building this all this evening) - [ ] Translations are missing Band-aid for nextcloud#1414, while we wait for a proper solution with libvips or somesuch.
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -424,13 +424,13 @@ | |
type: OC.SetupChecks.MESSAGE_TYPE_INFO | ||
}) | ||
} | ||
if (data.imageMagickLacksSVGSupport) { | ||
if (data.imageMagickLoaded) { | ||
messages.push({ | ||
msg: t( | ||
'core', | ||
'Module php-imagick in this instance has no SVG support. For better compatibility it is recommended to install it.' | ||
), | ||
type: OC.SetupChecks.MESSAGE_TYPE_INFO | ||
'Imagemagick is in use for document preview. This is not recommended out of security concerns, see the document preview documentation here:' | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
TLATER
Author
Owner
|
||
) + " <a href='https://docs.nextcloud.com/server/stable/admin_manual/configuration_files/previews_configuration.html'>https://docs.nextcloud.com/server/stable/admin_manual/configuration_files/previews_configuration.html</a>", | ||
type: OC.SetupChecks.MESSAGE_TYPE_WARNING | ||
}) | ||
} | ||
if (data.pendingBigIntConversionColumns.length > 0) { | ||
|
I'd recommend clarifying the document types Imagemagick affects. Otherwise, some not familiar with the topic might think this affects all image previews in general.
Something along the lines "Imagemagick is in use for SVG document previews. […]" might work.
(Though, I dunno if there are any other types/mime-types affected.)
And if we can say for certain, that it's a PHP module: "PHP-module imagemagick […]" (provide as much clear information as possible) =)