Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

[http-server] add exchangeId lock #65

Open
mistermoe opened this issue Nov 3, 2023 · 2 comments
Open

[http-server] add exchangeId lock #65

mistermoe opened this issue Nov 3, 2023 · 2 comments
Assignees
Labels
bug Something isn't working tbdex-server HTTP server for tbDEX PFIs

Comments

@mistermoe
Copy link
Contributor

lock on exchangeId. should only be able to add 1 message to a given exchange at any time

@mistermoe mistermoe changed the title [http-server] [http-server] add exchangeId lock Nov 3, 2023
@mistermoe mistermoe added the bug Something isn't working label Nov 3, 2023
@phoebe-lew phoebe-lew added the tbdex-server HTTP server for tbDEX PFIs label Nov 10, 2023
@mistermoe mistermoe self-assigned this Nov 15, 2023
@phoebe-lew phoebe-lew moved this to Todo in SDK Development Nov 15, 2023
@diehuxx
Copy link

diehuxx commented Jan 14, 2024

Is it possible to do this at the http-server level? Since ExchangeApi only deals with getting messages, I interpreted that the callback is what should save a given message. If that's the case, it's up to the implementer of the callback to manage a lock.

@diehuxx
Copy link

diehuxx commented Feb 23, 2024

Addressed by #168. Though my previous comment still stands. The consumer of http-server must store the messages in an exchange by leveraging callbacks and ExchangeApi. Assuming the consumer has stored messages and exposed them to http-server via ExchangeApi, the Exchange state machine in #168 will handle the rest.

Disregard, I misread the intent of this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working tbdex-server HTTP server for tbDEX PFIs
Projects
Status: No status
Development

No branches or pull requests

3 participants