Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint 42 upgrade weaver webservice 2.1.1 rc7 #43

Merged

Conversation

rmathew1011
Copy link
Contributor

Resolves #42

@rmathew1011 rmathew1011 changed the base branch from main to sprint-upgrade-staging April 21, 2022 21:35
@rmathew1011 rmathew1011 requested review from a user, jeremythuff, jcreel and rladdusaw April 26, 2022 16:08
@ghost ghost requested a review from kaladay April 27, 2022 13:28
Copy link
Contributor

@kaladay kaladay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests pass.

However, I have just attempted to run this using mvn clean spring-boot:run with Java 11 and this fails to start up.

08:30:17.205 [main] ERROR org.springframework.boot.SpringApplication - Application run failed
java.lang.IllegalArgumentException: Could not resolve placeholder 'catalina.home' in value "${catalina.home}/logs/application.log"

I'm wondering if this is the result of changing it from a war to a jar.

Does catalina.home now need to be added to the config?

@ghost
Copy link

ghost commented Apr 27, 2022

The tests pass.

However, I have just attempted to run this using mvn clean spring-boot:run with Java 11 and this fails to start up.

08:30:17.205 [main] ERROR org.springframework.boot.SpringApplication - Application run failed
java.lang.IllegalArgumentException: Could not resolve placeholder 'catalina.home' in value "${catalina.home}/logs/application.log"

I'm wondering if this is the result of changing it from a war to a jar.

Does catalina.home now need to be added to the config?

The log path needs to change. Catlina home is only applicable to tomcat deployment.

@ghost ghost closed this Apr 27, 2022
@ghost ghost reopened this Apr 27, 2022
@kaladay
Copy link
Contributor

kaladay commented Apr 27, 2022

I suggest the following changes for making the tests easier to read when running.
Change src/test/resources/application.properties to have the following:

logging.level.org.tdl: ERROR
logging.level.edu.tamu: ERROR
logging.level.org.springframework: ERROR
logging.level.org.hibernate: OFF
logging.level.ro.isdc.wro: ERROR
logging.level.com.zaxxer: ERROR

Create the file src/test/resources/logback-test.xml with the following content:

<?xml version="1.0" encoding="UTF-8"?>
<configuration>
  <include resource="org/springframework/boot/logging/logback/base.xml"/>
  <logger name="com.zaxxer" level="ERROR"/>
  <logger name="org.hibernate" level="OFF"/>
  <logger name="org.springframework" level="ERROR"/>
  <logger name="org.tdl" level="ERROR"/>
  <logger name="edu.tamu" level="ERROR"/>
  <logger name="ro.isdc.wro" level="ERROR"/>
  <property name="root.level.console" value="OFF"/>
</configuration>

@rmathew1011 rmathew1011 merged commit 9449540 into sprint-upgrade-staging Apr 27, 2022
@ghost ghost deleted the sprint_42_upgrade_weaver_webservice_2.1.1-rc7 branch June 20, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Weaver-Webservice-Core (2.1.1-RC10)
2 participants