Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recon ids as reaction names #333

Closed
2 tasks done
mihai-sysbio opened this issue Nov 8, 2021 · 4 comments
Closed
2 tasks done

Recon ids as reaction names #333

mihai-sysbio opened this issue Nov 8, 2021 · 4 comments

Comments

@mihai-sysbio
Copy link
Member

Description of the issue:

Some reactions (145) use the old Recon ids as reaction names.

Expected feature/value/output:

If the reaction names cannot be filled in from an appropriate source, they should be left empty.

Current feature/value/output:

Recon ids as reaction names.

Reproducing these results:

I hereby confirm that I have:

  • Done this analysis in the main branch of the repository
  • Checked that a similar issue does not exist already
@haowang-bioinfo
Copy link
Member

Removing recon ids from reaction names (#334) is fine with me.

This issue is related to #181, which discussed about adding descriptive reaction names. What do you think? @mihai-sysbio

@mihai-sysbio
Copy link
Member Author

Having the Recon ids as reaction names is easy to fix, and the improvement will be directly visible in Metabolic Atlas, so I suggest to keep the issues separate. I'll share my thoughts on #181 there.

@mihai-sysbio
Copy link
Member Author

This issue appears to be resolved by #334 so I propose closing it, while leaving #181 open, since that's where the new relation names would one in.

@haowang-bioinfo
Copy link
Member

sure, please go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants