-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radarr upgrade to V3 reports incorrect service startup on Synology #4285
Comments
Until the package is fixed you can use this workaround. Find the file: Change this line( line number 37): into: If radarr is still running, stop it from within radarr. |
Hi there, In addition there is following remark within the Radarr->System-> Status Page: Everything else (expect the not correct status in DSM and the hint to upgrade to.NET Core) seems to work actually. How should I proceed in order to have those things solved to? Regards & Thx for your great work there |
Maybe you should read my post placed just before yours before asking a solution already given. And upgrading to .NET core is no option for now and in the immediate future, because there is no .NET core for Synology available. |
Hi @BenjV, thanks for your comment. I've actually already documented the workaround here: #3987 (comment). What I really need help with is the pull request I made related to this issue: #4276 |
I cannot help with that, please ask one of the SynoCommunity admins. |
chmod: changing permissions of ‘service-setup’: Operation not permitted |
I cannot change that file BenjV. Pls help. |
Stop Radarr
Change the file with this command:
Start Radarr from the package center. |
sudo -i first You must make yourself root first |
Yes, done. But it still shows not running however the icon is back on synology dsm desktop |
What do you mean with shows not running? |
Even worse now, it aint working at all anymore. I use nightly builds. |
Use this command to show the file and look if the line is correct now.
|
root@SynologyNAS:~# cat /var/packages/radarr/scripts/service-setup
### Package specific variables and functions
# Base service USER to run background process prefixed according to DSM
USER="radarr"
PRIV_PREFIX=sc-
SYNOUSER_PREFIX=svc-
if [ -n "${SYNOPKG_DSM_VERSION_MAJOR}" -a "${SYNOPKG_DSM_VERSION_MAJOR}" -lt 6 ] ; then EFF_USER="${SYNOUSER_PREFIX}${USER}"; else EFF_USER="${PRIV_PREFIX}${USER }"; fi
# Service port
SERVICE_PORT="8310"
# start-stop-status script redirect stdout/stderr to LOG_FILE
LOG_FILE="${SYNOPKG_PKGDEST}/var/${SYNOPKG_PKGNAME}.log"
# Service command has to deliver its pid into PID_FILE
PID_FILE="${SYNOPKG_PKGDEST}/var/${SYNOPKG_PKGNAME}.pid"
# Invoke shell function if available
call_func ()
{
FUNC=$1
if type "$FUNC" 2>/dev/null | grep -q 'function' 2>/dev/null; then
if [ -n "${INST_LOG}" ]; then
echo "Invoke $FUNC" >> ${INST_LOG}
fi
eval ${FUNC}
fi
}
PATH="${SYNOPKG_PKGDEST}/bin:${PATH}"
MONO_PATH="/var/packages/mono/target/bin"
MONO="${MONO_PATH}/mono"
# Check versions during upgrade
RADARR="${SYNOPKG_PKGDEST}/share/Radarr/Radarr.exe"
SPK_RADARR="${SYNOPKG_PKGINST_TEMP_DIR}/share/Radarr/Radarr.exe"
# Radarr uses custom Config and PID directories
HOME_DIR="${SYNOPKG_PKGDEST}/var"
CONFIG_DIR="${SYNOPKG_PKGDEST}/var/.config"
PID_FILE="${CONFIG_DIR}/Radarr/radarr.pid
# Some have it stored in the root of package
LEGACY_CONFIG_DIR="${SYNOPKG_PKGDEST}/.config"
# workaround for mono bug with armv5 (https://github.com/mono/mono/issues/12537)
if [ "$SYNOPKG_DSM_ARCH" == "88f8621" -o "$SYNOPKG_DSM_ARCH" == "88f8622" ]; the n
MONO="MONO_ENV_OPTIONS='-O=-aot,-float32' ${MONO_PATH}/mono"
fi
GROUP="sc-download"
LEGACY_GROUP="sc-media"
SERVICE_COMMAND="env PATH=${MONO_PATH}:${PATH} HOME=${HOME_DIR} LD_LIBRARY_PATH= ${SYNOPKG_PKGDEST}/lib ${MONO} ${RADARR}"
SVC_BACKGROUND=y
service_postinst ()
{
# Move config.xml to .config
mkdir -p ${CONFIG_DIR}/Radarr
mv ${SYNOPKG_PKGDEST}/app/config.xml ${CONFIG_DIR}/Radarr/config.xml
set_unix_permissions "${CONFIG_DIR}"
# If nessecary, add user also to the old group before removing it
syno_user_add_to_legacy_group "${EFF_USER}" "${USER}" "${LEGACY_GROUP}"
syno_user_add_to_legacy_group "${EFF_USER}" "${USER}" "users"
# Discard legacy obsolete busybox user account
BIN=${SYNOPKG_PKGDEST}/bin
$BIN/busybox --install $BIN >> ${INST_LOG}
$BIN/delgroup "${USER}" "users" >> ${INST_LOG}
$BIN/deluser "${USER}" >> ${INST_LOG}
}
service_preupgrade ()
{
# We have to account for legacy folder in the root
# It should go, after the upgrade, into /var/.config/
# The /var/ folder gets automatically copied by service-installer after this
if [ -d "${LEGACY_CONFIG_DIR}" ]; then
echo "Moving ${LEGACY_CONFIG_DIR} to ${INST_VAR}" >> ${INST_LOG}
mv ${LEGACY_CONFIG_DIR} ${CONFIG_DIR} >> ${LOG_FILE} 2>&1
else
# Create, in case it's missing for some reason
mkdir ${CONFIG_DIR} >> ${LOG_FILE} 2>&1
fi
# Is Installed Radarr Binary Ver. >= SPK Radarr Binary Ver.?
CUR_VER=$(${MONO_PATH}/monodis --assembly ${RADARR} | grep "Version:" | awk '{print $2}')
echo "Installed Radarr Binary: ${CUR_VER}" >> ${INST_LOG}
SPK_VER=$(${MONO_PATH}/monodis --assembly ${SPK_RADARR} | grep "Version:" | awk '{print $2}')
echo "Requested Radarr Binary: ${SPK_VER}" >> ${INST_LOG}
if [ "${CUR_VER//.}" -ge "${SPK_VER//.}" ]; then
echo 'KEEP_CUR="yes"' > ${CONFIG_DIR}/KEEP_VAR
echo "[KEEPING] Installed Radarr Binary - Upgrading Package Only" >> ${I NST_LOG}
mv ${SYNOPKG_PKGDEST}/share ${INST_VAR}
else
echo 'KEEP_CUR="no"' > ${CONFIG_DIR}/KEEP_VAR
echo "[REPLACING] Installed Radarr Binary" >> ${INST_LOG}
fi
}
service_postupgrade ()
{
# Restore Current Radarr Binary if Current Ver. >= SPK Ver.
. ${CONFIG_DIR}/KEEP_VAR
if [ "$KEEP_CUR" == "yes" ]; then
echo "Restoring Radarr version from before upgrade" >> ${INST_LOG}
rm -fr ${SYNOPKG_PKGDEST}/share >> $INST_LOG 2>&1
mv ${INST_VAR}/share ${SYNOPKG_PKGDEST}/ >> $INST_LOG 2>&1
set_unix_permissions "${SYNOPKG_PKGDEST}/share"
fi
set_unix_permissions "${CONFIG_DIR}"
# If backup was created before new-style packages
# new updates/backups will fail due to permissions (see #3185)
set_unix_permissions "/tmp/radarr_backup"
set_unix_permissions "/tmp/radarr_update"
# Remove upgrade Flag
rm ${CONFIG_DIR}/KEEP_VAR
It is. |
Most likely Radar is still running. |
It is not running, i checked. I do have the Docker version running at port 7878 though. |
do a:
See if there is a pidfile Check if radarr still running with:
|
|
He is making the correct pidfile so the fix is working. Maybe try to reboot your Nas. Otherwise I am out of idea's, most likely a vague docker problem. |
I will try a reboot. I run the non docker version as well as docker together. I will also stop the docker version to test. |
My fix is for the normal version only. |
Use Docker version 3 |
How use same package center? how to install docker? and witch relase? |
You are using docker; download client DS station places downloads in /volume1/Video/Downloads but this directory does not appear to exist inside the container. Review your remote path mappings and container volume settings. |
https://github.com/Radarr/Radarr/wiki/Health-Checks#update-to-net-core-version
|
@BenjV I have the same issue as @wvkreg but I'm running the Synology package, not Docker. I tried the same things mentioned above and Radarr doesn't work at all anymore. When I click Run, nothing happens (I got the error before). This is what my result is so far:
I've also restarted a few times and still can't get Radarr to run. I could try uninstalling and reinstalling, but I'd lose all my info and don't want to do that. |
Hi @severdia, looking at your Radarr config folder above it seems that Radarr does think it's running. We see the PID file the DB files seem open for writing as well. My suggestion would be to restart your NAS with the Radarr service not set to startup (Control Panel > Info Center > Service). Once this is done the databases should be in a clean state for you to perform a manual backup. Copy this entire folder out to another location. You can even make a manual backup archive yourself (for v3, it's usually a folder named 'radarr_backup_v3' with just two files 'config.xml' and 'radarr.db'). That way you have a starting point to restore your configuration in the event a reinstall is required. |
Given that my pull request (#4276) which resolves the service startup issue was merged into the master codebase I will be closing this issue. |
@houndtt Thank you, however it appears I won't be able to update if I can't get it running (no, it's not active in the startup and it's not running on the assigned port). Is there an article somewhere describing how to do the backup/restore you mentioned? Looking around the server, I don't see any Radarr files. |
Thanks @houndtt for your contribution, The updated package is now live but may take up to 48 hours to show up in the package center due to caching. |
@severdia, as this issue is now closed, please open a new issue and I can assist you further there |
For new Package Requests, see the guidelines
Setup
Package Name: Radarr
Package Version: 20200921-11 (then with app update to v3.0.0.4204)
NAS Model: Synology
NAS Architecture: x64
DSM version: 6.2.3-25426 Update 2
Expected behavior
After running the built-in app update from version 0.2.0.1504 to version 3.0.0.4204 the app updates and the package in the Package Centre reports as 'Running'
Actual behavior
After running the built-in app update from version 0.2.0.1504 to version 3.0.0.4204 the app updates and the package in the Package Centre reports as 'Stopped' with an error 'Failed to run the package service' reported when the Run button is clicked
Steps to reproduce
1. Install clean Radarr 20200921-11 from SynoCommunity
2. In the Radarr interface under System > Updates, click Install Latest to update to V3
3. Refresh the Radarr interface to show the new V3 UI and then Shutdown the app
4. From the Package Center click on Run for the Radarr app
Package log
Check Package Center or
/usr/local/{package}/var/
Other logs
/var/log/messages
/var/log/synopkg.log
The text was updated successfully, but these errors were encountered: