Remove harcoded GRCh38
version for AnnotSv
#76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi thanks for this awesome open source tool! 🥇
My teammate @ddomenico and I noticed that
AnnotSV
runs a harcoded version ofGRCh38
, even though the README instructions provide commands to download reference files like the Exomiser data in versionhg19
.Germline-StructuralV-nf/modules/annotsv.nf
Lines 32 to 41 in 8865708
Using
GRCh38
orGRCh37
should be configurable through aparam
. I added theparam.genomeBuild
to annotation removing the hardcodedGRCh38
. And setGRCh37
as default to match the README example.