Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): adapt to zenodo jsonld changes. Send referer on Zenodo request #3643

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

Panaetius
Copy link
Member

We had some left over code fo fix zenodo context, that I think was mostly useless and got broken during a refactoring, but now Zenodo made a new release where that code applies again and the broken part screws up the import. so I just removed that part and things should work again.

Zenodo now also requires the "Referer" header to be set, and only accepts requests from specific, whitelisted referes. We're not whitelisted. This is really stupid, I could just set it to zenodo.org and it'd work... For now I've added code to properly set a referer and then we need to check about getting whitelisted.

@coveralls
Copy link
Collaborator

coveralls commented Oct 17, 2023

Pull Request Test Coverage Report for Build 7098439873

  • 19 of 24 (79.17%) changed or added relevant lines in 1 file are covered.
  • 328 unchanged lines in 32 files lost coverage.
  • Overall coverage decreased (-0.5%) to 85.494%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/dataset/providers/zenodo.py 19 24 79.17%
Files with Coverage Reduction New Missed Lines %
renku/command/schema/dataset.py 1 91.94%
renku/core/dataset/providers/api.py 1 83.26%
renku/core/dataset/providers/common.py 1 94.44%
renku/core/dataset/providers/repository.py 1 88.46%
renku/core/dataset/providers/s3.py 1 96.25%
renku/core/dataset/providers/web.py 1 89.91%
renku/core/migration/models/v3.py 1 97.24%
renku/core/storage.py 1 79.79%
renku/core/util/os.py 1 88.89%
renku/core/workflow/activity.py 1 93.93%
Totals Coverage Status
Change from base Build 7061396825: -0.5%
Covered Lines: 26409
Relevant Lines: 30890

💛 - Coveralls

@Panaetius Panaetius marked this pull request as draft October 17, 2023 14:23
@Panaetius Panaetius force-pushed the fix-zenodo-import branch 3 times, most recently from 8b0c870 to dfaf985 Compare December 1, 2023 14:34
@Panaetius Panaetius force-pushed the fix-zenodo-import branch 11 times, most recently from d4c8932 to db49192 Compare December 4, 2023 13:09
@Panaetius Panaetius marked this pull request as ready for review December 5, 2023 18:44
@Panaetius Panaetius removed the on hold label Dec 5, 2023
@Panaetius Panaetius merged commit 41816d8 into develop Dec 5, 2023
29 checks passed
@Panaetius Panaetius deleted the fix-zenodo-import branch December 5, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants