Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the --force-build flag should not be in the docker section #3612

Closed
rokroskar opened this issue Sep 5, 2023 · 1 comment · Fixed by #3641
Closed

the --force-build flag should not be in the docker section #3612

rokroskar opened this issue Sep 5, 2023 · 1 comment · Fixed by #3641
Assignees
Labels
kind/bug status/triage Issue needs to be triaged

Comments

@rokroskar
Copy link
Member

rokroskar commented Sep 5, 2023

The --force-build flag to renku session start appears in the "docker configuration" section of the help text - it should be in the "options" section as it is "native" to renku. Using that flag results in an error:

TypeError: run() got an unexpected keyword argument 'force_build'
@rokroskar rokroskar added kind/bug status/triage Issue needs to be triaged labels Sep 5, 2023
@github-project-automation github-project-automation bot moved this to Backlog in renku-python Sep 5, 2023
@Panaetius Panaetius moved this from Backlog to Ready in renku-python Oct 11, 2023
@Panaetius Panaetius moved this from Ready to In Progress in renku-python Oct 16, 2023
@Panaetius Panaetius self-assigned this Oct 16, 2023
@Panaetius
Copy link
Member

I addressed the bug in a PR but the "docker" section of the docs is for the docker provider, not for docker the software, force-build is exclusive for the docker provider (it doesn't exist on the renkulab provider), so I left that as is.

@github-project-automation github-project-automation bot moved this from In Progress to Done in renku-python Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug status/triage Issue needs to be triaged
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants