Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): parse security_opt as list not tuple #3587

Merged
merged 1 commit into from
Aug 15, 2023
Merged

fix(cli): parse security_opt as list not tuple #3587

merged 1 commit into from
Aug 15, 2023

Conversation

olevski
Copy link
Member

@olevski olevski commented Aug 14, 2023

closes #3552

@olevski olevski requested a review from a team as a code owner August 14, 2023 12:03
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5855433205

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 20 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.07%) to 85.789%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/core/workflow/activity.py 1 93.93%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 74.07%
renku/ui/service/views/error_handlers.py 1 87.17%
renku/core/util/git.py 5 85.07%
renku/ui/service/controllers/graph_export.py 10 57.14%
Totals Coverage Status
Change from base Build 5830131281: -0.07%
Covered Lines: 25843
Relevant Lines: 30124
💛 - Coveralls

@olevski olevski merged commit 80770a5 into develop Aug 15, 2023
@olevski olevski deleted the fix-3552-renku-session-start branch August 15, 2023 09:53
olevski added a commit that referenced this pull request Aug 23, 2023
@olevski
fix(cli): parse security_opt as list not tuple (#3587)
d74d35f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: renku session start -p docker
3 participants
@olevski @coveralls @Panaetius