Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): pass docker run args to session start #3487

Merged
merged 2 commits into from
May 31, 2023

Conversation

mohammad-alisafaee
Copy link
Contributor

Description

Adds some of docker run args to renku session start.

Fixes #3395
Fixes #3388

@coveralls
Copy link
Collaborator

coveralls commented May 29, 2023

Pull Request Test Coverage Report for Build 5132524504

  • 15 of 21 (71.43%) changed or added relevant lines in 3 files are covered.
  • 16 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.05%) to 85.324%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/session/docker.py 12 18 66.67%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 68.59%
renku/ui/service/cache/models/file.py 1 93.15%
renku/ui/service/errors.py 1 82.2%
renku/ui/service/views/error_handlers.py 1 85.16%
renku/command/rollback.py 2 78.7%
renku/ui/service/jobs/cleanup.py 2 81.82%
renku/core/session/docker.py 5 62.13%
Totals Coverage Status
Change from base Build 5118979911: -0.05%
Covered Lines: 25704
Relevant Lines: 30125

💛 - Coveralls

@mohammad-alisafaee mohammad-alisafaee force-pushed the 3395-session-start-with-docker-run-flags branch from a7e4e49 to 65c6814 Compare May 30, 2023 22:43
@mohammad-alisafaee mohammad-alisafaee force-pushed the 3395-session-start-with-docker-run-flags branch 3 times, most recently from e8c01b7 to 2485d21 Compare May 31, 2023 07:04
@mohammad-alisafaee mohammad-alisafaee marked this pull request as ready for review May 31, 2023 09:45
@mohammad-alisafaee mohammad-alisafaee requested a review from a team as a code owner May 31, 2023 09:45
@mohammad-alisafaee mohammad-alisafaee force-pushed the 3395-session-start-with-docker-run-flags branch from 30ab837 to 413c1fb Compare May 31, 2023 09:47
@mohammad-alisafaee mohammad-alisafaee merged commit 9cbb465 into develop May 31, 2023
@mohammad-alisafaee mohammad-alisafaee deleted the 3395-session-start-with-docker-run-flags branch May 31, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants