Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): pretty session list output with additional fields #3397

Merged
merged 2 commits into from
Apr 19, 2023
Merged

feat(cli): pretty session list output with additional fields #3397

merged 2 commits into from
Apr 19, 2023

Conversation

Panaetius
Copy link
Member

closes #3042

@Panaetius Panaetius requested a review from a team as a code owner April 13, 2023 13:24
@coveralls
Copy link
Collaborator

coveralls commented Apr 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4691031198

  • 29 of 29 (100.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+9.6%) to 86.244%
Files with Coverage Reduction New Missed Lines %
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 60.21%
Totals Coverage Status
Change from base Build 4687758207: 9.6%
Covered Lines: 25756
Relevant Lines: 29864
💛 - Coveralls

mohammad-alisafaee
mohammad-alisafaee approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@mohammad-alisafaee mohammad-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Panaetius Panaetius merged commit d8feb83 into develop Apr 19, 2023
@Panaetius Panaetius deleted the feature/3042-session-ls-more-fields branch April 19, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammad-alisafaee mohammad-alisafaee mohammad-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

renku session ls should show commit hash and start time
3 participants
@Panaetius @coveralls @mohammad-alisafaee