-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): do not update template if dockerfile is modified #3396
Conversation
f5e80b2
to
0ccd804
Compare
Pull Request Test Coverage Report for Build 4813552425
💛 - Coveralls |
0ccd804
to
f8923c6
Compare
f8923c6
to
1c67720
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions and questions.
Do we need more extensive documentation changes to explain the formating and content of the Dockerfile sections and logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mohammad.
Description
A Renku-specific section can be added to a Dockerfile. Any lines of the Dockerfile that are between begin and end end markers must not be modified by users. This section is used to calculate Dockerfile checksum (empty lines and whitespaces at the end of lines are ignored). If it's missing then we use the whole Dockerfile.
When updating a template, Renku only update this section if it exists in both project and template Dockerfile; otherwise, the whole Dockerfile is overridden.
Fixes #3354