-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): fix dataset update with external files #3379
Conversation
f359b1c
to
e6b9d17
Compare
Pull Request Test Coverage Report for Build 5068211394
💛 - Coveralls |
Pull Request Test Coverage Report for Build 4533833387
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ralf! This is great! I understand that the dataset part is quite confusing and it's good to have others to look into it. The refactoring you did is nice. Suggestions for more refactoring are welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ralf! Please see my comments.
…sDataScienceCenter/renku-python into bugfix/3363-external-dataset-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
closes #3363