Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix dataset update with external files #3379

Merged
merged 13 commits into from
May 25, 2023

Conversation

Panaetius
Copy link
Member

closes #3363

@Panaetius Panaetius changed the title bugfix(cli): fix dataset update with external files fix(cli): fix dataset update with external files Mar 27, 2023
@Panaetius Panaetius force-pushed the bugfix/3363-external-dataset-update branch from f359b1c to e6b9d17 Compare March 27, 2023 15:41
@coveralls
Copy link
Collaborator

coveralls commented Mar 27, 2023

Pull Request Test Coverage Report for Build 5068211394

  • 206 of 229 (89.96%) changed or added relevant lines in 14 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+21.3%) to 85.298%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/dataset/dataset.py 29 32 90.63%
renku/core/dataset/providers/git.py 45 49 91.84%
renku/core/dataset/providers/api.py 42 47 89.36%
renku/core/dataset/providers/local.py 33 38 86.84%
renku/core/dataset/providers/web.py 41 47 87.23%
Files with Coverage Reduction New Missed Lines %
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 68.59%
Totals Coverage Status
Change from base Build 5065889892: 21.3%
Covered Lines: 25730
Relevant Lines: 30165

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4533833387

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 4529773607: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@Panaetius Panaetius marked this pull request as ready for review March 29, 2023 09:13
@Panaetius Panaetius requested a review from a team as a code owner March 29, 2023 09:13
Copy link
Contributor

@mohammad-alisafaee mohammad-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf! This is great! I understand that the dataset part is quite confusing and it's good to have others to look into it. The refactoring you did is nice. Suggestions for more refactoring are welcome.

renku/core/dataset/dataset.py Outdated Show resolved Hide resolved
renku/core/dataset/dataset.py Outdated Show resolved Hide resolved
renku/core/dataset/providers/api.py Outdated Show resolved Hide resolved
renku/core/dataset/providers/api.py Show resolved Hide resolved
renku/core/dataset/providers/api.py Outdated Show resolved Hide resolved
renku/core/dataset/providers/api.py Outdated Show resolved Hide resolved
renku/core/dataset/providers/api.py Show resolved Hide resolved
renku/core/dataset/providers/git.py Show resolved Hide resolved
renku/core/dataset/providers/local.py Show resolved Hide resolved
Copy link
Contributor

@mohammad-alisafaee mohammad-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf! Please see my comments.

renku/core/dataset/dataset.py Show resolved Hide resolved
renku/core/dataset/providers/api.py Outdated Show resolved Hide resolved
renku/core/dataset/providers/api.py Show resolved Hide resolved
Copy link
Contributor

@mohammad-alisafaee mohammad-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Panaetius Panaetius enabled auto-merge (squash) May 25, 2023 08:27
@Panaetius Panaetius merged commit e02e5bf into develop May 25, 2023
@Panaetius Panaetius deleted the bugfix/3363-external-dataset-update branch May 25, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

External datasets update fails
3 participants