-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(service): return proper errors on migrations check #3334
Conversation
0ffb67b
to
6a8f94c
Compare
6a8f94c
to
f710119
Compare
9c63b8f
to
39dbf8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please see my comments.
…nt. (#3384) * feat(service): add support for doctor check in cache migration endpoint.
c05ab1a
to
580ed9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ralf! It's mainly about docstring updates. Should we use a named-tuple for the return value of doctor checks? It's getting more complicated.
closes #2124