Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): login to remote gitlab by default #3287

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

mohammad-alisafaee
Copy link
Contributor

@mohammad-alisafaee mohammad-alisafaee commented Jan 20, 2023

Description

Makes --git the default in renku login. Adds a --no-git option to avoid git login. Moves business logic from renku/command/login.py to renku/core/login.py

Fixes #3249

@mohammad-alisafaee mohammad-alisafaee marked this pull request as ready for review January 23, 2023 08:26
@mohammad-alisafaee mohammad-alisafaee requested a review from a team as a code owner January 23, 2023 08:26
renku/core/login.py Show resolved Hide resolved
@mohammad-alisafaee mohammad-alisafaee enabled auto-merge (squash) January 23, 2023 12:52
@mohammad-alisafaee mohammad-alisafaee merged commit 58bd96c into develop Jan 23, 2023
@mohammad-alisafaee mohammad-alisafaee deleted the 3249-renku-login branch January 23, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make renku login enable GitLab auth access by default
2 participants