feat(app): surface message and status when pod is unschedulable #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olevski
force-pushed
the
feat-surface-unschedulable-message
branch
from
7b0608f to
2965ec7
Compare
Panaetius
approved these changes
Jun 10, 2022
Comment on lines
+240
to
+249
| @classmethod | ||
| def from_value(cls, val: str): | ||
| if not val: | ||
| return None | ||
| if not val.lower() in cls.list(): | ||
| raise ValueError( | ||
| f"Value {val.lower()} cannot be found in list {cls.list()}" | ||
| ) | ||
| return getattr(cls, val.capitalize()) | ||
|
|
There was a problem hiding this comment.
Is this needed? You can already do e.g. ServerStatusEnum("running") (for value) or ServerStatusEnum["Running"] (for key)
And I don't see it used in the code.
There was a problem hiding this comment.
I will merge this but open another PR to remove this. I guess I thought I needed it and then figured out I can do what you suggest. This is not used at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on SwissDataScienceCenter/amalthea#165
closes #1017
For now I have decided to use the "failed" status for unschedulable sessions. We can add a dedicated or different status in the future if this is confusing to users. IMO however it is nicer to keep the number of potential session statuses small and simple.