squashme: make error messages properly surface #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panaetius
approved these changes
May 17, 2022
Panaetius
added a commit
that referenced
this pull request
May 18, 2022
* squashme: make error messages properly surface (#1064) Co-authored-by: Ralf Grubenmann <[email protected]> Co-authored-by: Tasko Olevski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Panaetius as mentioned in #1055 this will make the error codes properly surface all the way to the user.
Before in all cases the error code was the generic one that had no details.
Note that the target of this PR is your feature branch.