fix(app): handle user names in git clone #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to reproduce this by adding a middle name to my account. With the fix on my personal deployment it works. But on dev things fail. |
rokroskar
reviewed
Apr 6, 2022
|
The integration tests are failing because gitlab closes the connection. This happens often lately. |
rokroskar
reviewed
Apr 6, 2022
olevski
force-pushed
the
fix-name-in-git-clone
branch
from
32d4539 to
da98882
Compare
rokroskar
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem with names with a middle name during the setup of the repo when launching a session.
This was introduced by the conversion of the "git clone" code from bash to python.