Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gitlab] sometimes tsrc push does not see all merge requests #80

Closed
dmerejkowsky opened this issue Dec 4, 2017 · 1 comment
Closed

[gitlab] sometimes tsrc push does not see all merge requests #80

dmerejkowsky opened this issue Dec 4, 2017 · 1 comment

Comments

@dmerejkowsky
Copy link
Collaborator

Environment

tsrc version 0.3.2 - git: 6d50779

Steps to reproduce

  • Create a merge request (let's say for feat/foo branch)
  • Wait until many merge requests are opened
$ git checkout feat/foo
$ tsrc push

Actual output

Error message about merge request already existing

Expected result

Previous merge request should be found and updated instead of trying to create a new one
@dmerejkowsky
Copy link
Collaborator Author

dmerejkowsky commented Dec 4, 2017 •
edited
Loading

Note: it seems the request we make to the gitlab API does not return all merge requests, but just a fraction on them. To be investigated.

@maximerety maximerety mentioned this issue Feb 2, 2018
Merged
dmerejkowsky pushed a commit that referenced this issue Feb 6, 2018
@maximerety @dmerejkowsky
Partial fix for undetected merge requests (issue #80)
b0d4a54 
Two changes that should reduce the frequency of the issue:
  - filter opened merge requests directly when calling the GitLab API
  - increase page size to the maximum (100 items) in pagination

If you have more than 100 opened merge requests, issue #80 may still occur.
dmerejkowsky pushed a commit that referenced this issue Feb 6, 2018
@maximerety @dmerejkowsky
Fix for undetected merge requests due to pagination (issue #80)
7313647 
By following the X-NEXT-PAGE header of the previous API request,
we get all merge requests by pages of 100 items (max allowed).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maximerety @dmerejkowsky