Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map choice button can be unintentionally cloned sometimes #182

Open
AlchlcDvl opened this issue Jan 8, 2025 · 3 comments · May be fixed by #186
Open

Map choice button can be unintentionally cloned sometimes #182

AlchlcDvl opened this issue Jan 8, 2025 · 3 comments · May be fixed by #186
Labels
bug Something is broken

Comments

@AlchlcDvl
Copy link

AlchlcDvl commented Jan 8, 2025

Describe the bug
The map options picker has buttons to select a map, however sometimes, due to behaviour from other mods or somehow reloading the options menu, the button for choosing submerged gets cloned.

Expected behaviour
There should be only one button like in this image. Ignore the extra icons as those are from my mod and I got this image via introducing a fix on my end.
image

Screenshots
This is what it currently appears without the fix.
image

Version:

  • Among Us: 2024.11.26
  • Submerged: 2024.8.26

Additional context
It can be easily fixed by checking whether or not an instance of MapIconByName for submerged already exists in the list here:

__instance.AllMapIcons.Insert(4, new MapIconByName

@AlchlcDvl AlchlcDvl added the bug Something is broken label Jan 8, 2025
@AlchlcDvl
Copy link
Author

To add on to this, constantly doing this can also result in way too many submerged buttons like here
image

@Alexejhero
Copy link
Member

The Submerged button is only added during GameOptionsMapPicker.Initialize, which is only called once basically.
I cannot reproduce this - This looks like an incompatibility with another mod.

@AlchlcDvl
Copy link
Author

yes it's mainly an issue with compatibility with other mods

@AlchlcDvl AlchlcDvl linked a pull request Jan 30, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Development

Successfully merging a pull request may close this issue.

2 participants