Added sublime_lib dependency. #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@randy3k Any chance you can take a look at the PowerShell stuff? I've never worked with it and I don't have a Windows machine to test it with. |
randy3k
reviewed
Apr 25, 2019
| @@ -68,6 +68,24 @@ Bootstrap() { | |||
| echo | |||
| fi | |||
|
|
|||
| SUBLIME_LIB_PATH="$STP/coverage" | |||
There was a problem hiding this comment.
This path should $STP/sublime_lib
randy3k
reviewed
Apr 25, 2019
| @@ -73,6 +73,24 @@ Bootstrap() { | |||
| echo | |||
| fi | |||
|
|
|||
| SUBLIME_LIB_PATH="$STP/coverage" | |||
randy3k
requested changes
Apr 25, 2019
randy3k
force-pushed
the
master
branch
15 times, most recently
from
7690bbf to
fbf0a56
Compare
|
If a package requests a library, it is installed by Package Control. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used for #155, #67, and probably many other things.
I'm not familiar with PowerShell; we'll need to add sublime_lib in there as well. I also have not tested the CI integration.
Ideally, we could move most of the installation code into Python, relying on
pathliband other built-in cross-platform functionality. In a perfect world, it would be nice to make this a full-fledged pypi package.