Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Перейти на FrozenDictionary в Structure #81

Closed
Stepami opened this issue Aug 6, 2024 · 0 comments · Fixed by #83
Closed

[feature request] Перейти на FrozenDictionary в Structure #81

Stepami opened this issue Aug 6, 2024 · 0 comments · Fixed by #83
Labels
FrontEnd Working on frontend of the interpreter Improvement
Milestone
v2.0.0

Comments

@Stepami
Copy link
Owner

Stepami commented Aug 6, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
https://github.com/Stepami/hydrascript/blob/master/src/Domain/HydraScript.Domain.FrontEnd/Lexer/Impl/Structure.cs

Словарь создаётся один раз и затем постоянно читается в процессе парсинга

Describe the solution you'd like
Использовать FrozenDictionary вместо Dictionary

Additional context
https://steven-giesel.com/blogPost/34e0fd95-0b3f-40f2-ba2a-36d1d4eb5601
@Stepami Stepami added Good First Issue Good for newcomers FrontEnd Working on frontend of the interpreter Improvement labels Aug 6, 2024
@Stepami Stepami added this to the v2.0.0 milestone Aug 6, 2024
@FoxTes FoxTes mentioned this issue Aug 10, 2024
Merged
@Stepami Stepami linked a pull request Aug 10, 2024 that will close this issue
Перейти на FrozenDictionary в Structure. #83
Merged
@Stepami Stepami removed the Good First Issue Good for newcomers label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FrontEnd Working on frontend of the interpreter Improvement
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Перейти на FrozenDictionary в Structure. FoxTes/hydrascript
1 participant
@Stepami