remove attrs even if they don't start with data-

Fixes phoenixframework#3044

assets/js/phoenix_live_view/dom.js

@@ -406,7 +406,7 @@ let DOM = {
     for(let i = targetAttrs.length - 1; i >= 0; i--){
       let name = targetAttrs[i].name
       if(isIgnored){
-        if(name.startsWith("data-") && !source.hasAttribute(name) && ![PHX_REF, PHX_REF_SRC].includes(name)){ target.removeAttribute(name) }
+        if(!source.hasAttribute(name) && ![PHX_REF, PHX_REF_SRC].includes(name)){ target.removeAttribute(name) }
       } else {
         if(!source.hasAttribute(name)){ target.removeAttribute(name) }
       }

test/e2e/test_helper.exs

@@ -65,6 +65,7 @@ defmodule Phoenix.LiveViewTest.E2E.Router do
       pipe_through(:browser)
 
       live "/3026", Phoenix.LiveViewTest.E2E.Issue3026Live
+      live "/3044", Phoenix.LiveViewTest.E2E.Issue3044Live
     end
   end
 end

test/e2e/tests/issues/3044.spec.js

@@ -0,0 +1,17 @@
+const { test, expect } = require("@playwright/test");
+const { syncLV } = require("../../utils");
+
+test("attributes on phx-update='ignore' can be toggled", async ({ page }) => {
+  await page.goto("/issues/3044");
+  await syncLV(page);
+
+  await expect(page.locator("input")).not.toHaveAttribute("disabled");
+  await page.locator("button").click();
+  await syncLV(page);
+
+  await expect(page.locator("input")).toHaveAttribute("disabled");
+  await page.locator("button").click();
+  await syncLV(page);
+
+  await expect(page.locator("input")).not.toHaveAttribute("disabled");
+});

test/support/e2e/issues/issue_3044.ex

@@ -0,0 +1,26 @@
+defmodule Phoenix.LiveViewTest.E2E.Issue3044Live do
+  use Phoenix.LiveView
+
+  @impl Phoenix.LiveView
+  def mount(_, _, socket) do
+    {:ok, assign(socket, :disabled, false)}
+  end
+
+  @impl Phoenix.LiveView
+  def handle_event("toggle", _, socket) do
+    {:noreply, update(socket, :disabled, &(not &1))}
+  end
+
+  @impl Phoenix.LiveView
+  def render(assigns) do
+    ~H"""
+    <input
+      value={if @disabled, do: "disabled", else: "not disabled"}
+      disabled={@disabled}
+      phx-update="ignore"
+      id="test-input"
+    />
+    <button phx-click="toggle">Toggle</button>
+    """
+  end
+end