Skip to content

Commit

Permalink
Merge branch 'fix_skipped_feedback' into development
Browse files Browse the repository at this point in the history
  • Loading branch information
SteffenDE committed Feb 2, 2024
2 parents 1d464cd + 4584468 commit cc37c1c
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions assets/js/phoenix_live_view/dom_patch.js
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,10 @@ export default class DOMPatch {
DOM.maybeAddPrivateHooks(toEl, phxViewportTop, phxViewportBottom)
DOM.cleanChildNodes(toEl, phxUpdate)
if(this.skipCIDSibling(toEl)){
// track inputs for applying phx-no-feedback, even if an element and
// its children are skipped
DOM.all(fromEl, "form", (form) => trackedForms.add(form))
if(fromEl.tagName === "FORM") trackedForms.add(fromEl)
// if this is a live component used in a stream, we may need to reorder it
this.maybeReOrderStream(fromEl)
return false
Expand Down

0 comments on commit cc37c1c

Please sign in to comment.