Skip to content

Commit

Permalink
Update CHANGELOG and deprecations
Browse files Browse the repository at this point in the history
  • Loading branch information
josevalim committed Feb 12, 2024
1 parent a55fefb commit b698e16
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
10 changes: 5 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
## 0.20.5 (2024-02-08)

### Deprecations
* Deprecate `phx-feedback-group`
* Deprecate `phx-feedback-group` introduced in the previous release, the goal is to move feedback handling into Elixir and out of the DOM

### Bug fixes
* Fix blur event on phx-debounce being dispatched incorrectly
* Fix `open_browser` not working on WSL for project under unix FS
* Fix `open_browser` not working on WSL for project under UNIX file systems
* Match browser stream insert ordering behavior in `LiveViewTest`
* Fix `phx-click-away` not working when element is partially hidden
* Fix `phx-feedback-for` classes not being applied in some cases
Expand Down Expand Up @@ -57,7 +57,7 @@
## 0.20.2 (2023-12-18)

### Bug fixes
* Fix javascript error when submitting a form that has in progress uploads
* Fix JavaScript error when submitting a form that has in progress uploads
* Fix JS command `:target` failing to work when used as phx-submit or phx-change with a selector-based target
* Fix `JS.focus()` failing to focus negative tabindex
* Fix `LiveViewTest` failing to remove items after stream reset
Expand All @@ -66,7 +66,7 @@

### Enhancements
* Speed up DOM patching performance 3-30x 🔥
* Support `handle_async` Lifecycle callback
* Support `handle_async` lifecycle callback
* Extend visibility checks for phx-click-away to better handle whether an element is visible in the viewport or not
* Allow `JS.patch` and `JS.navigate` to be tested with `render_click`
* Support `:supervisor` option to `assign_async` and `start_async`
Expand Down Expand Up @@ -106,7 +106,7 @@
* Fix error on form recovery with `auto_upload: true`
* Fix issue on form recovery where hidden inputs would be selected by mistake
* Fix form recovery when phx-change is a JS command
* Fix stream reset on nested live components with nested streams.
* Fix stream reset on nested live components with nested streams
* Fix window location resetting to null when using nested LiveView on connection error
* Fix anchors within contenteditable causing LiveSocket disconnects

Expand Down
4 changes: 1 addition & 3 deletions guides/client/form-bindings.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ _Note_: only the individual input is sent as params for an input marked with `ph
## Error Feedback

For proper error feedback on form updates, the error tags must specify which
input they belong to. This is accomplished with the `phx-feedback-for` and `phx-feedback-group` attributes.
input they belong to. This is accomplished with `phx-feedback-for`.

The `phx-feedback-for` annotation specifies the name (or id, for backwards compatibility) of the input it belongs to. Failing to add the `phx-feedback-for` attribute will result in displaying error messages for form fields that the user has not changed yet (e.g. required
fields further down on the page).
Expand Down Expand Up @@ -147,8 +147,6 @@ Now, any DOM container with the `phx-feedback-for` attribute will receive a
user input/focus. Using new CSS rules or tailwindcss variants allows you
errors to be shown, hidden, and styled as feedback changes.

Likewise, the `phx-feedback-group` attribute behaves similarly to `phx-feedback-for`, but allows error tags and inputs to specify a composite name for a group of inputs.

## Number inputs

Number inputs are a special case in LiveView forms. On programmatic updates,
Expand Down

0 comments on commit b698e16

Please sign in to comment.