Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launchOptions not in steam launch option but at the end of target in manual mode #625

Closed
swhoro opened this issue Dec 21, 2023 · 3 comments

Comments

@swhoro
Copy link

swhoro commented Dec 21, 2023

I want a game's launch option in steam is filled by launchOptions field in manifest.json, what should I do?

I find a related issue: #307, but I do not find append args to executable option.

@HazardousBackup
Copy link
Contributor

I can't say for sure because I'm not familiar enough with the codebase yet but maybe config.executable.appendArgsToExecutable is supposed to be parsedConfig.appendArgsToExecutable here:

if(config.executable.appendArgsToExecutable) {

Some quick and dirty testing on my part shows the change moves launchOptions in a Manual parser to the Steam Launch Options field instead of appending it to the executable and the append args to executable option, that is only available on ROM/Glob parsers, still works.

@cbartondock
Copy link
Collaborator

The issue is actually that the manual parser doesn't have a toggle for this at the moment, I think the right way to do it (in the spirit of the manual parser) is to just add a field to the JSON file that determines this behavior (whether the launchOptions appear in the target or separately in steam).

@cbartondock
Copy link
Collaborator

Screenshot 2024-04-18 120330
Will be fixed in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants