You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the initialization list it takes (moves) the db & stmt, but discards them on the body. The fix is to leave the body empty (I think the idea was to do other.{_db,_stmt} = nullptr instead, but that's not need as the move constructor from std::shared_ptr() will take care of that).
The text was updated successfully, but these errors were encountered:
polesapart
changed the title
Bad custom std::move behavior
Bad custom constructor behavior in #63 fix
Jan 10, 2017
The fix for #63 as in pull-request #64 have problems.
The custom constructor takes some members from the target object but nullifies them afterwards:
In the initialization list it takes (moves) the db & stmt, but discards them on the body. The fix is to leave the body empty (I think the idea was to do other.{_db,_stmt} = nullptr instead, but that's not need as the move constructor from std::shared_ptr() will take care of that).
The text was updated successfully, but these errors were encountered: