Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Volume #962

Closed
NNEU-1 opened this issue Jun 9, 2021 · 2 comments
Closed

Set Volume #962

NNEU-1 opened this issue Jun 9, 2021 · 2 comments
Labels
enhancement A new feature that would improve Spotifyd wontfix Issues that will not be fixed under any circumstances

Comments

@NNEU-1
Copy link
Contributor

NNEU-1 commented Jun 9, 2021

Hi,

I know that one can get the current Spotify volume by MPRIS or environmental variable with the on_song_change_hook, but is there any way to write the volume to Spotify ?

MPRIS doesn't work because it is a read-only property.

This would be massively useful if the volume is changed outside of Spotify; eg. by control knob.

If there is already a solution, please let me know.
Otherwise, consider this as a feature request.

@NNEU-1 NNEU-1 added the enhancement A new feature that would improve Spotifyd label Jun 9, 2021
@NNEU-1
Copy link
Contributor Author

NNEU-1 commented Jun 12, 2021

Hi,

I just had a look at the code myself to consider how this could happen.
I could image two ways;

  1. Using rspotify such as the seek and set position methods that are already implemented.
  2. Using the set_volume function provided by librespot.

The problem with No.1 is, that the entire rspotify implementation seems broken. It is known that none of the related methods are functional ( see #612 ).
Thus, using the same style of function for volume will be equally non-functional.

The problem with No.2 is, that this function is not public and thus cannot be accessed. This would require a change to Librespot, perhaps adding "VolumeSet" to the accessible spirc functions.

Speaking of which, there are two more volume control functions that could be used but aren't in the current version of spotifyd.

VolumeUp & VolumeDown that is.
They provide the possibility to change volume via dbus in 6% steps.
This might be of help to some. #963

@stale
Copy link

stale bot commented Sep 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issues that will not be fixed under any circumstances label Sep 10, 2021
@stale stale bot closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature that would improve Spotifyd wontfix Issues that will not be fixed under any circumstances
Projects
None yet
Development

No branches or pull requests

1 participant