Skip to content

Commit 1a1997c

Browse files
slondrPlecra
andauthored
Specify minimum rust version (#1127)
* Specify minimum rust version * specify minimum rust version in GitHub CI This improves the error reporting when the crate is compiled with older versions of rustc. Specifically, #1123 tracks instances of Ubuntu rustc giving obscure errors when users attempt to compile spotifyd With this change, this error becomes > error: package `spotifyd v0.3.3 (...)` cannot be built because it requires rustc 1.62 or newer, while the currently active rustc version is 1.61.0 which is much more helpful to users diagnosinig the issue. Co-authored-by: Marli Frost <[email protected]>
1 parent fc50b53 commit 1a1997c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/workflows/ci.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ jobs:
5555
runs-on: ${{ matrix.os }}
5656
strategy:
5757
matrix:
58+
rust: [stable, 1.62.0]
5859
os: [macos-latest, ubuntu-latest]
5960
include:
6061
- os: macos-latest
@@ -66,7 +67,7 @@ jobs:
6667
- name: Installing Rust toolchain
6768
uses: actions-rs/toolchain@v1
6869
with:
69-
toolchain: stable
70+
toolchain: ${{ matrix.rust }}
7071
override: true
7172
- name: Installing macOS dependencies
7273
if: matrix.os == 'macos-latest'

Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ description = "A Spotify daemon"
66
repository = "https://github.com/Spotifyd/spotifyd"
77
license = "GPL-3.0-only"
88
version = "0.3.3"
9+
rust-version = "1.62"
910

1011
[dependencies]
1112
alsa = { version = "0.5", optional = true }

0 commit comments

Comments
 (0)