Retain customized parameter values on rebuildSolid #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @apla thanks for the PR ! I just tried it locally , and I am running into an issue : every time I modify a parameter's default value after a first rebuild , I get a "ReferenceError: valueIndex is not defined" error . |
|
I've backported changeset from my own fork, so maybe something isn't correct. I'll try to build |
|
any news on this @apla ? perhaps I can help if something is amiss ? |
|
Actually I've found an issue, directly tied to this one. When error occured, parameters resetting to default. Working on fix.
How do you tested my pull request?
… On 22 Feb 2017, at 10:11, Mark Moissette ***@***.***> wrote:
any news on this @apla ? perhaps I can help if something is amiss ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@apla cool ! |
|
I'm fine with push/pull and merge.
As I understand, you're using rollup to build js packages. There is a two rollup configurations — cli and module. Additionally, there is a some npm scripts. What procedure (or script sequence) you're using to build, lift and test pull request locally?
… On 22 Feb 2017, at 18:00, Mark Moissette ***@***.***> wrote:
@apla cool !
For testing , I pretty much follow this : https://help.github.com/articles/checking-out-pull-requests-locally/
(mainly fetching & pulling your PR branch onto a local copy)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
reset paramControls only when param definitions can be collected
|
Found the error, just typo. Last three commits is for situation when the error is introduced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.