Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Documentation Improvements for MacOS / Playwright #117

Open
tbusillo opened this issue Jun 24, 2023 · 3 comments
Open

[REQUEST] Documentation Improvements for MacOS / Playwright #117

tbusillo opened this issue Jun 24, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@tbusillo
Copy link

What would you like to have implemented?

Note: This is a high-level issue, but I would like to offer to submit a PR generally addressing this issue. First, I wanted to see if a PR on the below would be considered/useful, and if so, what feedback there may be on implementation.

I would like to see some additions to the existing documentation/examples for setup with ARM-based MacOS systems and Playwright for local development. There is some documentation already included in the existing docs, but the existing example(s) were more Linux oriented and it took digging through a few closed issues/sometimes cryptic errors in order to finally get things running locally.

A little more specifically, I would like to add some additional details/maybe some troubleshooting steps to this section of the docs. I would also like to include a working example using serverless framework + playwright + ARM-based system in the examples.

Why would it be useful?

This would be useful to help developers more easily get started with and use the package in a local development environment using a setup that is becoming increasingly common for developers (e.g., M1 + MacOS + Playwright).

@tbusillo tbusillo added the enhancement New feature or request label Jun 24, 2023
@Sparticuz
Copy link
Owner

Sure. I don't have access to an M chip right now, so I won't be much help, hah!

@tbusillo
Copy link
Author

Sure. I don't have access to an M chip right now, so I won't be much help, hah!

Cool and totally understand! I will work on a PR and submit hopefully this weekend; feel free to ping me if ever need some user testing on an M1 as well!

@tbusillo
Copy link
Author

Wanted to provide a quick update and apologies for the delay with this. I just got done with a move and trying to get caught up. Will try to have a PR up for this this weekend!

@Sparticuz Sparticuz mentioned this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants