Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DaService::get_extraction_proof an async function #507

Closed
preston-evans98 opened this issue Jul 17, 2023 · 0 comments · Fixed by #511
Closed

Make DaService::get_extraction_proof an async function #507

preston-evans98 opened this issue Jul 17, 2023 · 0 comments · Fixed by #511
Assignees

Comments

@preston-evans98
Copy link
Member

Is your feature request related to a problem? Please describe.
"My get_extraction_proof is async and requires communication using the client. I solve this by just getting the extraction proof in get_finalized_at unconditionally. But I guess that makes some unnecessary work for pure full node mode." This feature request originated in Discord.

Describe the solution you'd like
Make DaService::get_extraction_proof an async function

Additional context
My (Preston's) response in Discord: "We can definitely make get_extraction_proof async as well. I had initially envisioned it as a mathematical operation - but it makes sense that it would be baked into the remote client."

@bkolad bkolad self-assigned this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants