From 8ca4f969b6e89cddb303b705f7e757a8bf59a929 Mon Sep 17 00:00:00 2001 From: Pavel Mikula Date: Wed, 14 Sep 2022 18:22:18 +0200 Subject: [PATCH 1/3] Update RSPEC --- analyzers/rspec/cs/S2115_c#.json | 12 ++-------- analyzers/rspec/cs/S3353_c#.html | 22 ++++++++++++++++++- analyzers/rspec/cs/S4423_c#.json | 12 +--------- analyzers/rspec/cs/S4426_c#.json | 9 +------- analyzers/rspec/cs/S4433_c#.json | 12 ++-------- analyzers/rspec/cs/S4792_c#.json | 5 +---- analyzers/rspec/cs/S5542_c#.html | 2 +- analyzers/rspec/cs/S5547_c#.json | 9 +------- analyzers/rspec/vbnet/S4423_vb.net.json | 12 +--------- analyzers/rspec/vbnet/S4792_vb.net.json | 5 +---- analyzers/rspec/vbnet/S5542_vb.net.html | 2 +- analyzers/rspec/vbnet/S5547_vb.net.json | 9 +------- .../src/SonarAnalyzer.CSharp/sonarpedia.json | 2 +- .../SonarAnalyzer.VisualBasic/sonarpedia.json | 2 +- 14 files changed, 36 insertions(+), 79 deletions(-) diff --git a/analyzers/rspec/cs/S2115_c#.json b/analyzers/rspec/cs/S2115_c#.json index 48f5a74c826..06f850109f2 100644 --- a/analyzers/rspec/cs/S2115_c#.json +++ b/analyzers/rspec/cs/S2115_c#.json @@ -33,16 +33,8 @@ "6.2.4" ], "ASVS 4.0": [ - "2.1.1", - "2.1.11", - "2.1.12", - "2.1.2", - "2.1.3", - "2.1.4", - "2.1.7", - "2.1.8", - "2.1.9", - "2.10.3" + "9.2.2", + "9.2.3" ] }, "quickfix": "unknown" diff --git a/analyzers/rspec/cs/S3353_c#.html b/analyzers/rspec/cs/S3353_c#.html index bf311a6bfe6..c01da85d836 100644 --- a/analyzers/rspec/cs/S3353_c#.html +++ b/analyzers/rspec/cs/S3353_c#.html @@ -4,7 +4,7 @@

Noncompliant Code Example

 public bool Seek(int[] input)
 {
-  int target = 32;  // Noncompliant
+  var target = 32;  // Noncompliant
   foreach (int i in input)
   {
     if (i == target)
@@ -15,6 +15,16 @@ 

Noncompliant Code Example

return false; }
+

or

+
+public class Sample
+{
+  public void Method()
+  {
+    var context = $"{nameof(Sample)}.{nameof(Method)}";  // Noncompliant (C# 10 and above only)
+  }
+}
+

Compliant Solution

 public bool Seek(int[] input)
@@ -30,4 +40,14 @@ 

Compliant Solution

return false; }
+

or

+
+public class Sample
+{
+  public void Method()
+  {
+    const string context = $"{nameof(Sample)}.{nameof(Method)}";
+  }
+}
+
diff --git a/analyzers/rspec/cs/S4423_c#.json b/analyzers/rspec/cs/S4423_c#.json index 8be24569af2..73a990fefd9 100644 --- a/analyzers/rspec/cs/S4423_c#.json +++ b/analyzers/rspec/cs/S4423_c#.json @@ -47,19 +47,9 @@ "6.2.4" ], "ASVS 4.0": [ - "1.9.2", - "2.8.3", - "2.9.3", - "6.2.2", - "6.2.3", - "6.2.4", - "6.2.5", - "6.2.6", - "6.2.7", "8.3.7", "9.1.2", - "9.1.3", - "9.2.1" + "9.1.3" ] }, "quickfix": "unknown" diff --git a/analyzers/rspec/cs/S4426_c#.json b/analyzers/rspec/cs/S4426_c#.json index dae6ad530f6..074908b3705 100644 --- a/analyzers/rspec/cs/S4426_c#.json +++ b/analyzers/rspec/cs/S4426_c#.json @@ -35,14 +35,7 @@ "A2" ], "ASVS 4.0": [ - "2.8.3", - "6.2.3", - "6.2.4", - "6.2.5", - "6.2.6", - "6.2.7", - "9.1.2", - "9.1.3" + "6.2.3" ] }, "quickfix": "unknown" diff --git a/analyzers/rspec/cs/S4433_c#.json b/analyzers/rspec/cs/S4433_c#.json index 50dbf23ebf1..266b04a149e 100644 --- a/analyzers/rspec/cs/S4433_c#.json +++ b/analyzers/rspec/cs/S4433_c#.json @@ -31,16 +31,8 @@ "6.2.4" ], "ASVS 4.0": [ - "2.1.1", - "2.1.11", - "2.1.12", - "2.1.2", - "2.1.3", - "2.1.4", - "2.1.7", - "2.1.8", - "2.1.9", - "2.10.3" + "9.2.2", + "9.2.3" ] }, "quickfix": "unknown" diff --git a/analyzers/rspec/cs/S4792_c#.json b/analyzers/rspec/cs/S4792_c#.json index 1811bd87fc4..4a5ee333097 100644 --- a/analyzers/rspec/cs/S4792_c#.json +++ b/analyzers/rspec/cs/S4792_c#.json @@ -34,10 +34,7 @@ ], "ASVS 4.0": [ "7.1.1", - "7.1.2", - "7.3.1", - "7.3.2", - "8.3.5" + "7.1.2" ] } } diff --git a/analyzers/rspec/cs/S5542_c#.html b/analyzers/rspec/cs/S5542_c#.html index e3b47a6e22d..ed9e5172be1 100644 --- a/analyzers/rspec/cs/S5542_c#.html +++ b/analyzers/rspec/cs/S5542_c#.html @@ -3,7 +3,7 @@
  • For block cipher encryption algorithms (like AES):