From 8bc3d27d7c604422aaa816328c6ad25d498bd471 Mon Sep 17 00:00:00 2001 From: Pavel Mikula Date: Thu, 24 Jun 2021 13:37:39 +0200 Subject: [PATCH] S2259: Add FP repro for #4537 --- .../TestCases/NullPointerDereference.cs | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/NullPointerDereference.cs b/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/NullPointerDereference.cs index e368c03ae52..5fe885958f1 100644 --- a/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/NullPointerDereference.cs +++ b/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/NullPointerDereference.cs @@ -819,5 +819,19 @@ string DoSomethingArg(IEnumerable list) return item.ToString(); // False Negative, item could be null here } } + + // https://github.com/SonarSource/sonar-dotnet/issues/4537 + class Repro_4537 + { + private void ConditionalAccess_NullCoalescing() + { + string someString = null; + + if (!someString?.Contains("a") ?? true) + Console.WriteLine("It's null or doesn't contain 'a'"); + else + Console.WriteLine(someString.Length); // Noncompliant FP, this path is unreachable + } + } }