Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2178 Rule message: Mention extracting right operand if applicable #8559

Closed
Tim-Pohlmann opened this issue Jan 17, 2024 · 0 comments · Fixed by #8598
Closed

Fix S2178 Rule message: Mention extracting right operand if applicable #8559

Tim-Pohlmann opened this issue Jan 17, 2024 · 0 comments · Fixed by #8598
Assignees
@martin-strecker-sonarsource
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Sprint: Hardening Fix FPs/FNs/improvements
Milestone
9.19

Comments

@Tim-Pohlmann
Copy link
Contributor

Tim-Pohlmann commented Jan 17, 2024 •
edited
Loading

S2178's message as defined in RSPEC:
Correct this "x" to "xx" [and extract the right operand to a variable if it should always be evaluated].
Our analyzer does not implement the optional part. This can lead developers into a trap, changing the behavior of their code without noticing.
Our analyzer should detect if the right operand is constant or a pure method, and if it is not, use the extended message.
@Tim-Pohlmann Tim-Pohlmann added Type: Improvement Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. labels Jan 17, 2024
@Tim-Pohlmann Tim-Pohlmann mentioned this issue Jan 17, 2024
Closed
@antonioaversa antonioaversa added the Sprint: Hardening Fix FPs/FNs/improvements label Jan 22, 2024
@antonioaversa antonioaversa added this to the 9.18 milestone Jan 22, 2024
Merged
@antonioaversa antonioaversa removed this from the 9.18 milestone Jan 26, 2024
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource added this to the 9.19 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Sprint: Hardening Fix FPs/FNs/improvements
Projects
None yet
Milestone
9.19
Development

Successfully merging a pull request may close this issue.

Fix S2178 Rule message: Mention extracting right operand if applicable SonarSource/sonar-dotnet
4 participants
@antonioaversa @Tim-Pohlmann @martin-strecker-sonarsource @cristian-ambrosini-sonarsource