Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce time spend in HasMatchingScope for SyntaxNode registration #8399

Closed
sebastien-marichal opened this issue Nov 23, 2023 · 1 comment · Fixed by #8396
Closed

Reduce time spend in HasMatchingScope for SyntaxNode registration #8399

sebastien-marichal opened this issue Nov 23, 2023 · 1 comment · Fixed by #8396
Assignees
@sebastien-marichal
Labels
Type: Performance It takes too long.
Milestone
9.15

Comments

@sebastien-marichal
Copy link
Contributor

The HasMatchingScope check method can be called only once per syntactic rules, today this method is called for each node analyzed by the syntactic rules.

When doing a RegisterNodeAction, do the check before by doing first a RegisterCompilationStartAction.
@sebastien-marichal sebastien-marichal self-assigned this Nov 23, 2023
@sebastien-marichal sebastien-marichal mentioned this issue Nov 23, 2023
Merged
@martin-strecker-sonarsource
Copy link
Contributor

Related #7411

@sebastien-marichal sebastien-marichal mentioned this issue Nov 29, 2023
Open
@sebastien-marichal sebastien-marichal added this to the 9.15 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastien-marichal sebastien-marichal

Labels
Type: Performance It takes too long.
Projects
None yet
Milestone
9.15
Development

Successfully merging a pull request may close this issue.

Remove HasMatchingScope from Execute for SyntaxNode SonarSource/sonar-dotnet
2 participants
@martin-strecker-sonarsource @sebastien-marichal