Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S1118 FN: empty primary constructor #8122

Closed
cristian-ambrosini-sonarsource opened this issue Oct 2, 2023 · 0 comments · Fixed by #8205
Closed

Fix S1118 FN: empty primary constructor #8122

cristian-ambrosini-sonarsource opened this issue Oct 2, 2023 · 0 comments · Fixed by #8205
Assignees
Labels
Area: C#12 C#12 related issues Type: False Negative Rule is NOT triggered when it should be.
Milestone

Comments

@cristian-ambrosini-sonarsource
Copy link
Contributor

The rule does not take into account when the class is defining an empty primary constructor.

public class PrimaryCtor() // FN
{
    public static string Concatenate(string s1, string s2)
    {
        return s1 + s2;
    }

    public static string Prop { get; set; }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C#12 C#12 related issues Type: False Negative Rule is NOT triggered when it should be.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants